-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinInternval is allowed to equal to MaxInterval Per IM spec #12782
Merged
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_min_max_interval
Dec 9, 2021
Merged
MinInternval is allowed to equal to MaxInterval Per IM spec #12782
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_min_max_interval
Dec 9, 2021
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
December 9, 2021 08:00
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller and
woody-apple
December 9, 2021 08:00
PR #12782: Size comparison from f18d8b7 to 085cea9 Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 9, 2021
yufengwangca
approved these changes
Dec 9, 2021
yunhanw-google
force-pushed
the
feature/fix_min_max_interval
branch
from
December 9, 2021 17:05
085cea9
to
a7a95b4
Compare
PR #12782: Size comparison from 5bb8377 to a7a95b4 Increases (6 builds for efr32, linux, mbed, p6, telink)
Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
/rebase |
woody-apple
force-pushed
the
feature/fix_min_max_interval
branch
from
December 9, 2021 18:18
a7a95b4
to
5a0e580
Compare
PR #12782: Size comparison from b6297f3 to 5a0e580 Increases (6 builds for efr32, linux, p6, telink)
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/fix_min_max_interval
branch
from
December 9, 2021 19:29
5a0e580
to
23b2b58
Compare
pullapprove
bot
requested review from
Byungjoo-Lee,
chshu,
dhrishi,
gjc13 and
xylophone21
December 9, 2021 19:37
PR #12782: Size comparison from 7a99b3d to 23b2b58 Increases (14 builds for efr32, esp32, linux, nrfconnect, p6, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per spec ticket, https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/4729, MinInternval is allowed to equal to MaxInterval Per IM spec
Change overview
Update ReadClient/ReadHandler to allow equal.
Testing
Update cirque test to validate this situation.